Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support optional cloudsql-proxy sidecar #125

Merged
merged 1 commit into from
Dec 27, 2023
Merged

feat: Support optional cloudsql-proxy sidecar #125

merged 1 commit into from
Dec 27, 2023

Conversation

brtkwr
Copy link
Contributor

@brtkwr brtkwr commented Dec 22, 2023 •
edited
Loading

About the changes

Closes #126

@brtkwr
Copy link
Contributor Author

brtkwr commented Dec 22, 2023

cc @chriswk @gastonfournier

@brtkwr brtkwr changed the title feat: Add cloudsql sidecar feat: Support optional cloudsql-proxy sidecar Dec 22, 2023
chriswk
chriswk approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Great that you assured that the sidecar is 100% optional. I'm going to merge this.

@chriswk chriswk merged commit e569828 into Unleash:main Dec 27, 2023
11 checks passed
@iamdmitrij
Copy link

iamdmitrij commented Dec 27, 2023 •
edited
Loading

Hi, I'm having deployment issues with new version 3.1.1 of this chart. I've traced back the problem to this PR in charts/unleash/templates/deployment.yaml#L67.

As far as I understand deployment of chart will fail if you use extra secrets in value file.

unleash:
  secrets:
    AUTH_TENANT_ID: test

Some logs:

Error: UPGRADE FAILED: template: unleash/charts/unleash/templates/deployment.yaml:67:27: executing "unleash/charts/unleash/templates/deployment.yaml" at <include "unleash.fullname" .>: error calling include: template: unleash/charts/unleash/templates/_helpers.tpl:14:14: executing "unleash.fullname" at <.Values.fullnameOverride>: can't evaluate field Values in type string
##[error]Error: UPGRADE FAILED: template: unleash/charts/unleash/templates/deployment.yaml:67:27: executing "unleash/charts/unleash/templates/deployment.yaml" at <include "unleash.fullname" .>: error calling include: template: unleash/charts/unleash/templates/_helpers.tpl:14:14: executing "unleash.fullname" at <.Values.fullnameOverride>: can't evaluate field Values in type string

@brtkwr
Copy link
Contributor Author

brtkwr commented Dec 27, 2023

This PR publishes version 3.1.0, not 3.0.11

@iamdmitrij
Copy link

Sorry, my bad. I'm using the newest version of this chart - 3.1.1.

@brtkwr
Copy link
Contributor Author

brtkwr commented Dec 27, 2023

Sorry about that, this should fix it: https://github.com/Unleash/helm-charts/pull/127/files

@brtkwr brtkwr deleted the brtknr/t-14943-add-cloudsql-sidecar-to-unleash-chart-fork branch December 27, 2023 16:05
@brtkwr brtkwr mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support optional CloudSQL proxy sidecar
3 participants
@brtkwr @iamdmitrij @chriswk