fix: Regression with secrets fullname #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkwr
force-pushed
the
brtknr/t-14943-add-cloudsql-sidecar-to-unleash-chart-fork
branch
from
05f4edd to
b3823ab
Compare
|
cc @chriswk |
brtkwr
force-pushed
the
brtknr/t-14943-add-cloudsql-sidecar-to-unleash-chart-fork
branch
from
7f4262b to
f3153a4
Compare
brtkwr
force-pushed
the
brtknr/t-14943-add-cloudsql-sidecar-to-unleash-chart-fork
branch
from
f3153a4 to
3a0ae5c
Compare
chriswk
approved these changes
Dec 28, 2023
brtkwr
deleted the
brtknr/t-14943-add-cloudsql-sidecar-to-unleash-chart-fork
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: #125, a bug was introduced related to injecting secret into pods if passed from the values file. This PR fixes the regression and adds test for secret injection.