Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup workflows #1177

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Cleanup workflows #1177

merged 7 commits into from
Nov 11, 2024

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Nov 6, 2024 •
edited
Loading

The recent upstream changes in ros2_control revealed some tech debt on our workflows. This PR updates them regarding

  • Proper naming of jobs for clearer identification
  • Correct naming of steps in reusable ici
  • Adding missing upstream packages from ros2_control in upstream workspaces
  • Fix workflow syntax in some places
  • Add ccache
  • Add MoveIt to upstream workspace -- this avoids installing ros2_control from binary packages.

@urfeex urfeex marked this pull request as ready for review November 7, 2024 10:32
@urfeex urfeex requested a review from VinDp November 7, 2024 10:32
@urfeex urfeex added the CI label Nov 7, 2024
VinDp
VinDp approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@VinDp VinDp merged commit f64ff97 into UniversalRobots:main Nov 11, 2024
10 of 12 checks passed
@urfeex urfeex deleted the fix_ci branch November 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinDp VinDp VinDp approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urfeex @VinDp