Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.7.0 - feat: SOR level implementation to support 1) expanding mixed quoter v1 to L2s 2) support migrate mixed quoter v1 to mixed quoter v2 across chains #746

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Oct 11, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    right now, mixed routing is only supported on L1 (plus L1 testnet).

  • What is the new behavior (if this is a feature change)?
    we want to be able to expand mixed routing support to L2s. There are multiple stages:

  1. routing-api to shadow sample mixed routing against mixed quoter v1 across L2s. There's no accuracy to compare, just make sure routing-api shadow mixed routing success rate is high - existing metrics in routing-api ON_CHAIN_QUOTE_PROVIDER_${this.EXACT_IN_METRIC}_TRAFFIC_TARGET_FAILED_CHAIN_ID_${this.chainId}
  2. routing-api to live traffic switch mixed routing against mixed quoter v1 across L2s. Again there's no accuracy to compare, but we can live switch gradually per chain. We will check the quote endpoint success rate doesn;'t drop.
  3. routing-api to shadow sampling mixed routing against mixed quoter v2. mixed quoter v2 contains v4 pools, but v4 is only deployed to sepolia, hence this can only happen after we deployed v4 to production nets. There are accuracy comparison.
  4. routing-api to live traffic switch mixed routing against mixed quoter v2. We will check the quote endpoint success rate doesn;'t drop.
  • Other information:
    routing-api needs some changes as well, in order to achieve 1-4

@jsy1218 jsy1218 marked this pull request as ready for review October 11, 2024 03:29
@jsy1218 jsy1218 requested a review from a team as a code owner October 11, 2024 03:29
@graphite-app graphite-app bot requested a review from cgkol October 11, 2024 03:35
@graphite-app graphite-app bot requested a review from xrsv October 11, 2024 03:35
Copy link

graphite-app bot commented Oct 11, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/11/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link
Contributor

@xrsv xrsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a no-op

src/providers/on-chain-quote-provider.ts Show resolved Hide resolved
@jsy1218 jsy1218 force-pushed the siyujiang/mixed-quoter-expanding-to-more-chains branch from e72f865 to ad517b2 Compare October 15, 2024 20:01
@jsy1218 jsy1218 merged commit a65a782 into main Oct 15, 2024
28 of 29 checks passed
@jsy1218 jsy1218 deleted the siyujiang/mixed-quoter-expanding-to-more-chains branch October 15, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants