-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sor to 4.7.0 - feat: SOR level implementation to support 1) expanding mixed quoter v1 to L2s 2) support migrate mixed quoter v1 to mixed quoter v2 across chains #868
Merged
jsy1218
merged 6 commits into
main
from
siyujiang/mixed-quoter-expanding-to-more-chains
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected] |
jsy1218
commented
Oct 11, 2024
jsy1218
commented
Oct 11, 2024
test/mocha/integ/handlers/quote/provider-migration/traffic-switch-quote-provider.test.ts
Show resolved
Hide resolved
xrsv
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - left a couple of comments
…1) expanding mixed quoter v1 to L2s 2) support migrate mixed quoter v1 to mixed quoter v2 across chains
jsy1218
force-pushed
the
siyujiang/mixed-quoter-expanding-to-more-chains
branch
from
October 15, 2024 20:23
aa9cc73
to
14953fd
Compare
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (10/15/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR compliments Uniswap/smart-order-router#746, and will be able to achieve:
On L2, only Base has the MixedRouteQuoterV1 deployed (see context). I thought its due to the lack of FOT and exact out support. But its actually due to SOR only enables mixed routing on L1 https://github.com/Uniswap/smart-order-router/blob/66927c4e4f7e75138df48afab1c33a6c6d8d8f15/src/routers/alpha-router/alpha-router.ts#L2081.
Therefore in this PR, I will only enable shadow sampling against Base mixed routing on L2, but keep 100% mixed routing traffic on L1.
I also enhanced existing unit test coverages.
tests all passed on my local https://app.warp.dev/block/afa5Lrn5JUeIIscuDGm14B
Tested on my personal AWS account: