Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update portadmin tests to use fixtures #2668

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Update portadmin tests to use fixtures #2668

merged 11 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. Add fixtures

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2dc8930 View commit details
    Browse the repository at this point in the history

  2. Use pytest fixtures instead of unittest for tests

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    716ab4d View commit details
    Browse the repository at this point in the history

  3. Remove unused import

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c4fd587 View commit details
    Browse the repository at this point in the history

  4. Import only what the module actually uses

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    47653a3 View commit details
    Browse the repository at this point in the history

  5. Separate hp and cisco tests

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e1b8dbd View commit details
    Browse the repository at this point in the history

  6. Remove something that is tested in other test

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    45c500a View commit details
    Browse the repository at this point in the history

  7. Put factory tests in separate class

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a2e3a8e View commit details
    Browse the repository at this point in the history

  8. Import vendor handlers directly

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    522a6b5 View commit details
    Browse the repository at this point in the history

  9. Use 'is not' for comparing against None

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d4e065d View commit details
    Browse the repository at this point in the history

  10. Replace camel-case

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1e54014 View commit details
    Browse the repository at this point in the history

  11. Compare against None using 'is' instead of '=='

    @stveit
    stveit committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    552c7b9 View commit details
    Browse the repository at this point in the history