Update portadmin tests to use fixtures #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
=======================================
Coverage 54.61% 54.61%
=======================================
Files 560 560
Lines 40712 40712
=======================================
Hits 22235 22235
Misses 18477 18477 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stveit
force-pushed
the
portadmin-tests-update
branch
from
4632423
to
0f62c1a
Compare
stveit
force-pushed
the
portadmin-tests-update
branch
from
f2d7670
to
522a6b5
Compare
stveit
changed the title
lunkwill42
requested changes
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portadmin tests need a revamp. Had issues writing new tests in #2635 because of how these tests are written.
This PR swaps from using unittest and setup/teardown to using fixtures, groups tests together better and fixes some other bad practices (importing all from a module using * for example)