Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row highlight on row select #33

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Nov 27, 2023

Implemented changes:

  • slightly increased contrast between colored data cells and row background (so that the contrast is universally acceptable on different row states)
  • hilghlighted checked rows by changing its background color

UI before:

Screenshot 2024-06-07 at 16 00 29

UI after:

Screenshot 2024-06-19 at 12 32 08

@podliashanyk podliashanyk added polish Nice to have zino labels Nov 27, 2023
@podliashanyk podliashanyk self-assigned this Nov 27, 2023
@podliashanyk podliashanyk mentioned this pull request Nov 27, 2023
2 tasks
@hmpf hmpf added the blocked Depends on other issue being solved label Jan 24, 2024
@podliashanyk podliashanyk added paused Assignee is busy with things of higher priority and removed blocked Depends on other issue being solved labels Jun 6, 2024
@podliashanyk podliashanyk force-pushed the bulk-select-with-row-highlight branch from 60c73dc to 1cbd8b9 Compare June 7, 2024 13:18
@podliashanyk podliashanyk reopened this Jun 7, 2024
@podliashanyk podliashanyk removed the paused Assignee is busy with things of higher priority label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Test results

  4 files    4 suites   8s ⏱️
14 tests 14 ✔️ 0 💤 0
56 runs  56 ✔️ 0 💤 0

Results for commit 87c1ee8.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1cbd8b9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   47.30%           
=======================================
  Files           ?       15           
  Lines           ?      890           
  Branches        ?        0           
=======================================
  Hits            ?      421           
  Misses          ?      469           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk marked this pull request as ready for review June 7, 2024 13:53
@podliashanyk podliashanyk force-pushed the bulk-select-with-row-highlight branch from 5957f43 to c7f39ef Compare June 20, 2024 08:33
@podliashanyk podliashanyk merged commit fc881e6 into main Jun 24, 2024
6 checks passed
@podliashanyk podliashanyk deleted the bulk-select-with-row-highlight branch June 24, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have zino
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants