Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple select #32

Merged
merged 45 commits into from
Nov 28, 2023
Merged

Add multiple select #32

merged 45 commits into from
Nov 28, 2023

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Nov 23, 2023 •
edited
Loading

Implemented changes:

  • Events can be selected/unselected for bulk updates via checkbox
  • At least 1 selected event promps bulk update menu. Menu disappears when no events are selected

Not implemented:

  • row highlight on select (nice to have for better UX Add row highlight on row select #33)
  • select/deselect all (nice to have as it is not a part of original functionality in Zino)
  • select on single click/alt click/KBD shortcut (nice to have)

podliashanyk and others added 30 commits August 16, 2023 13:50
@podliashanyk
Switch to using Zino1EventEngine
d1cb26a
@podliashanyk
Start refactoring fetching of events
7343b08
@podliashanyk
Working detailed view
15afcc7
@podliashanyk
Working version of switching to new EventEngine
ab6b4ee
@podliashanyk
Replace case with event
4ba4ab9
@podliashanyk
Remove redundancies after switching to new engine
edccc05
@podliashanyk
Refactor loading of table
22c69ae
@podliashanyk
Complete working event status update
09d8a2e
@podliashanyk
Implement notion of expanded and collapsed table rows
c7ac708 
Table row can be either in collapsed state, or in expanded state. Necessary for further changes (toggle row on click, colors etc)
@podliashanyk
Fix update status form after refactor
c2471bb
@podliashanyk
Clean up
b444d21
@podliashanyk
Merge branch 'refactor-expanded-and-collapsed-rows' into refactor-and…
8e11ea6 
…-cleanup
@podliashanyk
Toggle row on double click
63ec930
@podliashanyk
Make expanded row highlighted
3e4589b
@podliashanyk
Add color codes to adm_state column
3bab7fa
@podliashanyk
Add color coding to rest of event row
e386564
@podliashanyk
Add visual feedback on row toggle
1c993cd
@podliashanyk
Improve visual feedback on row toggle
ddde6ff
@podliashanyk
Make toggle row via svg work again
f2cd572
@podliashanyk
Make table view compact
abcc5cf 
Pluss minor text polish in state columns
@podliashanyk
Compress padding for event detailed view
61475d4
@hmpf @podliashanyk
Fix packaging of howitz
a6ae33f
@podliashanyk
Merge branch 'packaging-fix' into 'main'
40cfef8 
Fix packaging of howitz

See merge request zino/howitz!1
@podliashanyk
Merge branch 'main' into refactor-and-cleanup
52ed940
@podliashanyk
Delete redundant files again after merge
ce6ecab
@podliashanyk
Cleanup in files
15ec16c
@podliashanyk
Cleanup in client
61abcca
@podliashanyk
Add checkbox to event row
758a001
@podliashanyk
Upgrade htmx
49d52cf
@podliashanyk
Store state on selected events
716dfee
@podliashanyk podliashanyk self-assigned this Nov 23, 2023
@podliashanyk podliashanyk added enhancement New feature or request zino labels Nov 23, 2023
@podliashanyk podliashanyk marked this pull request as ready for review November 27, 2023 09:37
@podliashanyk podliashanyk changed the title Add bulk select Add multiple select Nov 27, 2023
hmpf
hmpf approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, works fine. Please rebase and clean up the history a little before merging.

@podliashanyk podliashanyk merged commit 733fe72 into Uninett:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

@johannaengland johannaengland Awaiting requested review from johannaengland

Assignees

@podliashanyk podliashanyk

Labels
enhancement New feature or request zino
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@podliashanyk @hmpf