Give React SPA frontend specific things a home #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results0 tests 0 ✅ 0s ⏱️ Results for commit c50013f. ♻️ This comment has been updated with latest results. |
hmpf
added
API
elfjes
reviewed
Oct 15, 2024
| if not CORS_ALLOWED_ORIGINS: | ||
| raise ImproperlyConfigured('"FRONTEND_URL" has not been set in production!') | ||
|
|
||
| COOKIE_DOMAIN = get_str_env("ARGUS_COOKIE_DOMAIN", required=True) |
There was a problem hiding this comment.
Is this still going to be required if we're not doing anything spa? And same question for ARGUS_FRONTEND_URL I think
There was a problem hiding this comment.
frontend url might be otherwise useful but cookie domain is spa only. I'll rename 'em I think, to make it clearer.
There was a problem hiding this comment.
ARGUS_FRONTEND_URL is only for CORS, right? I don't think we should have any cors if we don't have a spa?
hmpf
force-pushed
the
spa-frontend-specific
branch
4 times, most recently
from
b5ca8fc
to
bdc4900
Compare
hmpf
force-pushed
the
spa-frontend-specific
branch
from
bdc4900
to
c50013f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #904
We're moving away from the REACT frontend so we must make it easier to switch between the old and the new. One day we'll delete all the REACT frontend specific things, we ought to make it safe and easy.
This means settings-wrangling.
App settings come in two varieties:
Much have been written about the best way to tackle 1. Not much about 2.
Furthermore standard django settings are of two types: Overridable (like DEBUG) and should be mutated in place (MIDDLEWARE, TEMPLATES..) The trend is towards more complex settings like the latter.
Finally, there's what to do about the root urls.py.