Give React SPA frontend specific things a home #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I like where this is going :), Do you want to make |
hmpf
force-pushed
the
spa-frontend-specific
branch
from
2cf3e22
to
64b7a2e
Compare
It doesn't need to be. It has no models, templates, static files, template tags or other things that is autodiscovered. The goal is to delete the directory and anything mentioning "spa" one happy day. |
|
test_CI.py had DOS line ends which really sucks when "git add -p" with new code that has unix line ends. The commit "Strip \r from lineends" needs to go in .git_blame_ignore_revs when everything is ready. |
|
|
Replaced by #907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900
We're moving away from the REACT frontend so we must make it easier to switch between the old and the new. One day we'll delete all the REACT frontend specific things, we ought to make it safe and easy.
This means settings-wrangling.
App settings come in two varieties:
Much have been written about the best way to tackle 1. Not much about 2.
Furthermore standard django settings are of two types: Overridable (like DEBUG) and should be mutated in place (MIDDLEWARE, TEMPLATES..) The trend is towards more complex settings like the latter.
Finally, there's what to do about the root urls.py.