Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ASL-4566] PIL-E course purpose HE or training - Part 2 #80

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: [ASL-4566] PIL-E course purpose HE or training - Part 2 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5fa1c
minor refactor
kiran-varma-home-office Nov 6, 2024
f5133da
update lock file
kiran-varma-home-office Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions constants/training-course-purpose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const trainingCoursePurpose = {
'higher-education': 'Higher Education',
'training': 'Training',
higherEducation: 'Higher education',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in many places I saw higher-education called, Could you please have a look the changes to higherEducation not going to cause any trouble in other places

aspel-workspace/packages/asl-projects/client/helpers/index.js
aspel-workspace/packages/asl-schema/test/migrations/20200710110948_training_and_education_ppls_false.js
aspel-workspace/packages/asl-schema/migrations/20200710110948_training_and_education_ppls_false.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new const which is created here is used in all the places that this ticket needs.

I had a look at the files above, from what I see, new changes shouldn't impact old changes. Let's see duing testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo - please let me know if you have any more comments, I am happy to raise another PR if needed. I am going merge it now because I need this change to update other PR's.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kiran-varma-home-office

training: 'Training',
}

module.exports = trainingCoursePurpose;
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ukhomeoffice/asl-constants",
"version": "2.1.6",
"version": "2.1.7",
"description": "Shared constants for ASL modules",
"main": "index.js",
"scripts": {
Expand Down
Loading