feat: [ASL-4566] PIL-E course purpose HE or training - Part 2 #80
Conversation
github-actions
bot
force-pushed
the
feat/asl-4566-pile-course-purpose-part2
branch
from
ea7005c to
f5133da
Compare
| @@ -1,6 +1,6 @@ | |||
| const trainingCoursePurpose = { | |||
| 'higher-education': 'Higher Education', | |||
| 'training': 'Training', | |||
| higherEducation: 'Higher education', | |||
There was a problem hiding this comment.
in many places I saw higher-education called, Could you please have a look the changes to higherEducation not going to cause any trouble in other places
aspel-workspace/packages/asl-projects/client/helpers/index.js
aspel-workspace/packages/asl-schema/test/migrations/20200710110948_training_and_education_ppls_false.js
aspel-workspace/packages/asl-schema/migrations/20200710110948_training_and_education_ppls_false.js
There was a problem hiding this comment.
new const which is created here is used in all the places that this ticket needs.
I had a look at the files above, from what I see, new changes shouldn't impact old changes. Let's see duing testing
There was a problem hiding this comment.
@mo - please let me know if you have any more comments, I am happy to raise another PR if needed. I am going merge it now because I need this change to update other PR's.
There was a problem hiding this comment.
Thank you @kiran-varma-home-office
kiran-varma-home-office
deleted the
feat/asl-4566-pile-course-purpose-part2
branch
No description provided.