Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple modules that were performing scalar instead of spherical calculations #2717

Merged
merged 5 commits into from
Sep 25, 2024

Commits on Sep 21, 2024

  1. Fixes to multiple modules that were performing scalar (2D) calculatio…

    …ns when they should have been doing spherical (3D). Most changes were to nearestPointOnLine. pointToLineDistance now uses nearestPointOnLine for spherical calculations. Flow on corrections impacted lineSlice and nearestPointToLine as well.
    
    Tidied up some tests - fixed module name in test definitions, added a benchmark overall time in a few places for easier comparisons.
    smallsaucepan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    4cac6cd View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Configuration menu
    Copy the full SHA
    3aa07ee View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Added comments to clarify some sections. Started using our own toRadi…

    …ans and toDegrees functions from turf-helpers.
    smallsaucepan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b8aa471 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Updated test results that changed minutely due after swtiching to rad…

    …iansToDegress and degreesToRadians from turf-helpers. It seems (degrees * Math.PI) / 180 can sometimes differ slightly from degrees * (Math.PI / 180).
    smallsaucepan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4b4e72c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da639f3 View commit details
    Browse the repository at this point in the history