Fixed multiple modules that were performing scalar instead of spherical calculations #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns when they should have been doing spherical (3D). Most changes were to nearestPointOnLine. pointToLineDistance now uses nearestPointOnLine for spherical calculations. Flow on corrections impacted lineSlice and nearestPointToLine as well. Tidied up some tests - fixed module name in test definitions, added a benchmark overall time in a few places for easier comparisons.
|
Btw, benchmark performance tests for nearestPointOnLine were unchanged. |
twelch
approved these changes
Sep 24, 2024
Comment on lines
189
to
191
| posA: Position, | ||
| posB: Position, | ||
| posC: Position |
There was a problem hiding this comment.
Worth clarifying what each parameter is expected to be? I see you passing the posA - start point of segment, posB - end point of segment, posC - point to find nearest point on segment.
|
Thanks @twelch. Will implement all those suggestions and merge shortly. |
…ans and toDegrees functions from turf-helpers.
…iansToDegress and degreesToRadians from turf-helpers. It seems (degrees * Math.PI) / 180 can sometimes differ slightly from degrees * (Math.PI / 180).
|
Nice, this is just what i needed! |
|
Just what I was looking for! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed multiple modules that were performing scalar (2D) calculations when they should have been doing spherical (3D).
Most changes were to nearestPointOnLine. pointToLineDistance now uses nearestPointOnLine for spherical calculations. Flow on corrections impacted lineSlice and nearestPointToLine as well.
Should fix some long standing issues, and be a step towards Turf being internally consistent. For example, a point returned by nearestPointOnLine should have a pointToLineDistance of 0. Or (eventually) return true for booleanPointOnLine.
Resolves #965
Resolves #1156
Resolves #1514
Resolves #1878
Resolves #2023
Resolves #2234
Resolves #2270