Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded mingo to 6.4.6 #66

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgraded mingo to 6.4.6 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"@tryghost/mongo-knex": "^0.8.0",
"@tryghost/mongo-utils": "^0.5.0",
"@tryghost/nql-lang": "^0.5.0",
"mingo": "^2.2.2"
"mingo": "^6.4.5"
}
}
3 changes: 3 additions & 0 deletions packages/nql/test/unit/api.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ describe('Public API', function () {
});

it('ensure caching works as expected', function () {
// Ensure mingo.Query can be spied on
Object.defineProperty(mingo, 'Query', {writable: true, value: mingo.Query});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to do this to allow sinon to spy on Query due to how the export is defined (Object.defineProperty with writeable defaulting to false)


sandbox.spy(mingo, 'Query');
sandbox.spy(nqlLang, 'parse');

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3350,10 +3350,10 @@ min-indent@^1.0.0:
resolved "https://registry.yarnpkg.com/min-indent/-/min-indent-1.0.1.tgz#a63f681673b30571fbe8bc25686ae746eefa9869"
integrity sha512-I9jwMn07Sy/IwOj3zVkVik2JTvgpaykDZEigL6Rx6N9LbMywwUSMtxET+7lVoDLLd3O3IXwJwvuuns8UB/HeAg==

mingo@^2.2.2:
version "2.5.3"
resolved "https://registry.yarnpkg.com/mingo/-/mingo-2.5.3.tgz#bed3db76ca9b2cc29ae1f1ff83e3a8797dc47758"
integrity sha512-Wb98QEQ/DaT+xPQFAX08mzM/Zz2eW1UIpKH132gXglakl2SKYBCQFzeiFygS/Hgzc9j9MDDjgouB9W7BMaLyaQ==
mingo@6.4.5:
version "6.4.5"
resolved "https://registry.yarnpkg.com/mingo/-/mingo-6.4.5.tgz#786d6182dcd953c8dc054529d2c3e4497202af0f"
integrity sha512-ezEfIWciAJVYjX76SeOFp0TiJnoDFt3ACqF0yNMIsvOP/MVWUzmmQ0AIcwIafsD3TMirLnbvDhIBr8VfHxxIxQ==

[email protected]:
version "3.0.5"
Expand Down