Upgraded mingo to 6.4.6
#66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 9 9
Lines 1551 1551
Branches 313 313
=======================================
Hits 1233 1233
Misses 313 313
Partials 5 5 ☔ View full report in Codecov by Sentry. |
mike182uk
commented
Sep 28, 2023
| @@ -68,6 +68,9 @@ describe('Public API', function () { | |||
| }); | |||
|
|
|||
| it('ensure caching works as expected', function () { | |||
| // Ensure mingo.Query can be spied on | |||
| Object.defineProperty(mingo, 'Query', {writable: true, value: mingo.Query}); | |||
There was a problem hiding this comment.
We have to do this to allow sinon to spy on Query due to how the export is defined (Object.defineProperty with writeable defaulting to false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded
mingoto 6.4.6 due to older versions not playing nicely withvitewhen bundled up (due to invalidmodulereference inpackage.json)