Fix kl/at merging #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximusunc
reviewed
Aug 23, 2024
| @@ -27,6 +27,9 @@ def update(self, other): | |||
| f"Model {self.__class__.__name__} has no update method" | |||
| ) | |||
|
|
|||
| def get_field(self, field): | |||
There was a problem hiding this comment.
What is this used for?
There was a problem hiding this comment.
I was originally going to use this method, but this is what we had discussed before, which provides a method to get an arbitrary field, if it exists for that model.
maximusunc
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both #81 and #80
This update will remove extra KL/AT attributes when merging edges together. It doesn't use any creative logic here, and does not change the existing KL/AT attributes, even if the removed one provides additional information.