Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple knowledge level and agent type #80

Closed
cbizon opened this issue Aug 12, 2024 · 1 comment · Fixed by #82
Closed

Multiple knowledge level and agent type #80

cbizon opened this issue Aug 12, 2024 · 1 comment · Fixed by #82
Assignees

Comments

@cbizon
Copy link

cbizon commented Aug 12, 2024

Here is an edge from aragorn (which uses reasoner-pydantic to merge edges). It contains two attributes with type agent_type and two with knowledge_level. This is disallowed per https://github.com/NCATSTranslator/ReasonerAPI/blob/master/ImplementationGuidance/Specifications/knowledge_level_agent_type_specification.md

I notice that the text-mining-kp is being referenced via two paths (service provider and robokop) so I suspect that this is an edge merging edge case :)

{
    "subject": "CHEBI:6129",
    "object": "NCBIGene:8653",
    "predicate": "biolink:affects",
    "sources": [
        {
            "resource_id": "infores:text-mining-provider-targeted",
            "resource_role": "primary_knowledge_source",
            "upstream_resource_ids": []
        },
        {
            "resource_id": "infores:service-provider-trapi",
            "resource_role": "aggregator_knowledge_source",
            "upstream_resource_ids": [
                "infores:text-mining-provider-targeted"
            ]
        },
        {
            "resource_id": "infores:aragorn",
            "resource_role": "aggregator_knowledge_source",
            "upstream_resource_ids": [
                "infores:automat-robokop",
                "infores:service-provider-trapi"
            ]
        },
        {
            "resource_id": "infores:automat-robokop",
            "resource_role": "aggregator_knowledge_source",
            "upstream_resource_ids": [
                "infores:text-mining-provider-targeted"
            ]
        }
    ],
    "qualifiers": [
        {
            "qualifier_type_id": "biolink:object_aspect_qualifier",
            "qualifier_value": "activity_or_abundance"
        },
        {
            "qualifier_type_id": "biolink:qualified_predicate",
            "qualifier_value": "biolink:causes"
        },
        {
            "qualifier_type_id": "biolink:object_direction_qualifier",
            "qualifier_value": "decreased"
        }
    ],
    "attributes": [
        {
            "attribute_type_id": "biolink:knowledge_level",
            "value": "not_provided",
            "value_type_id": "EDAM:data_0006",
            "original_attribute_name": "knowledge_level"
        },
        {
            "attribute_type_id": "biolink:publications",
            "value": [
                "PMC:5522823"
            ],
            "value_type_id": "linkml:Uriorcurie",
            "original_attribute_name": "publications"
        },
        {
            "attribute_type_id": "biolink:primary_knowledge_source",
            "value": "infores:text-mining-provider-targeted",
            "value_type_id": "biolink:InformationResource",
            "attribute_source": "infores:text-mining-provider-targeted"
        },
        {
            "attribute_type_id": "biolink:evidence_count",
            "value": 1,
            "value_type_id": "biolink:EvidenceCount",
            "attribute_source": "infores:text-mining-provider-targeted"
        },
        {
            "attribute_type_id": "biolink:publications",
            "value": [
                "PMC:5522823"
            ],
            "value_type_id": "biolink:Uriorcurie",
            "attribute_source": "infores:pubmed"
        },
        {
            "attribute_type_id": "biolink:agent_type",
            "value": "text_mining_agent",
            "value_type_id": "EDAM:data_0006",
            "original_attribute_name": "agent_type"
        },
        {
            "attribute_type_id": "biolink:has_supporting_study_result",
            "value": "tmkp:4ebdb684feb412402016a32105f08073f8c308e6d3257ad7609c64fe468427a8",
            "value_type_id": "biolink:TextMiningResult",
            "value_url": "https://tmui.text-mining-kp.org/evidence/4ebdb684feb412402016a32105f08073f8c308e6d3257ad7609c64fe468427a8",
            "attribute_source": "infores:text-mining-provider-targeted",
            "attributes": [
                {
                    "attribute_type_id": "biolink:supporting_text",
                    "value": "Ketorolac salt is a newly discovered DDX3 inhibitor to treat oral cancer",
                    "value_type_id": "EDAM:data_3671",
                    "attribute_source": "infores:text-mining-provider-targeted"
                },
                {
                    "attribute_type_id": "biolink:publications",
                    "value": "PMC:5522823",
                    "value_type_id": "biolink:Uriorcurie",
                    "value_url": "https://pubmed.ncbi.nlm.nih.gov/PMC5522823/",
                    "attribute_source": "infores:pubmed"
                },
                {
                    "attribute_type_id": "biolink:supporting_text_located_in",
                    "value": "reference",
                    "value_type_id": "IAO_0000314",
                    "attribute_source": "infores:pubmed"
                },
                {
                    "attribute_type_id": "biolink:extraction_confidence_score",
                    "value": 0.99971837,
                    "value_type_id": "EDAM:data_1772",
                    "attribute_source": "infores:text-mining-provider-targeted"
                },
                {
                    "attribute_type_id": "biolink:subject_location_in_text",
                    "value": "0|9",
                    "value_type_id": "SIO:001056",
                    "attribute_source": "infores:text-mining-provider-targeted"
                },
                {
                    "attribute_type_id": "biolink:object_location_in_text",
                    "value": "37|41",
                    "value_type_id": "SIO:001056",
                    "attribute_source": "infores:text-mining-provider-targeted "
                },
                {
                    "attribute_type_id": "biolink:supporting_document_year",
                    "value": 2017,
                    "value_type_id": "UO:0000036",
                    "attribute_source": "infores:pubmed"
                }
            ]
        },
        {
            "attribute_type_id": "biolink:knowledge_level",
            "value": "not_provided"
        },
        {
            "attribute_type_id": "biolink:Attribute",
            "value": 0.99971837,
            "value_type_id": "EDAM:data_0006",
            "original_attribute_name": "tmkp_confidence_score"
        },
        {
            "attribute_type_id": "biolink:extraction_confidence_score",
            "value": 0.99971837,
            "value_type_id": "biolink:ConfidenceLevel",
            "attribute_source": "infores:text-mining-provider-targeted"
        },
        {
            "attribute_type_id": "biolink:Attribute",
            "value": "Ketorolac salt is a newly discovered DDX3 inhibitor to treat oral cancer|NA",
            "value_type_id": "EDAM:data_0006",
            "original_attribute_name": "sentences"
        },
        {
            "attribute_type_id": "biolink:supporting_data_source",
            "value": "infores:pubmed",
            "value_type_id": "biolink:InformationResource",
            "attribute_source": "infores:text-mining-provider-targeted"
        },
        {
            "attribute_type_id": "biolink:Attribute",
            "value": [
                "tmkp:fc2a3fd2a9f2f06ea19ea2ff2cd24a10a9e49b828803de90bd2c42e9f5dcab48",
                "tmkp:4ebdb684feb412402016a32105f08073f8c308e6d3257ad7609c64fe468427a8"
            ],
            "value_type_id": "EDAM:data_0006",
            "original_attribute_name": "tmkp_ids"
        },
        {
            "attribute_type_id": "biolink:agent_type",
            "value": "text_mining_agent"
        }
    ]
}
@cbizon
Copy link
Author

cbizon commented Aug 12, 2024

See NCATSTranslator/Feedback#811 for the original issue.

@uhbrar uhbrar linked a pull request Aug 23, 2024 that will close this issue
@uhbrar uhbrar closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants