Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(DAPP-400): fixes broken tests #35

Merged
merged 8 commits into from
Nov 23, 2023
Merged

tests(DAPP-400): fixes broken tests #35

merged 8 commits into from
Nov 23, 2023

Conversation

Kelz29
Copy link
Contributor

@Kelz29 Kelz29 commented Nov 15, 2023 •
edited
Loading

Description

Add/fixes broken tests

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Desktop Request Success Tokens
  • Tablet Request Success Tokens
  • Mobile Request Success Tokens

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Kelz29 Kelz29 self-assigned this Nov 15, 2023
@Kelz29 Kelz29 mentioned this pull request Nov 15, 2023
Closed
10 tasks
KalervoHyyppa
KalervoHyyppa suggested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to reduce the use of Future.delayed

KalervoHyyppa
KalervoHyyppa approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kelz29 Kelz29 merged commit 3d0f6bf into dev Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berriose berriose berriose approved these changes

@KalervoHyyppa KalervoHyyppa KalervoHyyppa approved these changes

@lukorito lukorito Awaiting requested review from lukorito

Assignees

@Kelz29 Kelz29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kelz29 @berriose @KalervoHyyppa