Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(DAPP-410): Time out in get first populated block #34

Closed
wants to merge 7 commits into from
Closed

bug(DAPP-410): Time out in get first populated block #34

wants to merge 7 commits into from

Conversation

KalervoHyyppa
Copy link
Contributor

Description

Adds Timeout for get first populated block

Fixes # (issue)

DAPP-410

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KalervoHyyppa KalervoHyyppa marked this pull request as ready for review November 13, 2023 20:25
Kelz29
Kelz29 suggested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Kelz29 Kelz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/blocks/providers/block_provider.dart Outdated Show resolved Hide resolved
lib/transactions/utils/utils.dart Outdated
return outputLvls.map((e) {
return e.value.lvl.quantity.value.toBigInt;
}).toList();
print('QQQQ $outputLvls');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up? Unless we leaving them for further testing? If so, we should probably add a TODO:

pubspec.yaml Show resolved Hide resolved
test/requests/request_tokens_test.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelz29 Kelz29 Kelz29 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KalervoHyyppa @Kelz29