-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decrypt attestations and show list of identifiers #52
Conversation
WalkthroughThe changes involve significant updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
src/services/eas/query.ts (1)
Line range hint
54-99
: Remove commented-out old code.The commented-out old code is not necessary and can be removed to keep the codebase clean.
Apply this diff to remove the commented-out old code:
-// const useGetAttestations = () => { -// return useQuery({ -// queryKey: ['getAttestations'], -// queryFn: async () => { -// const result = await graphQLClient.request(gql` -// query Attestations { -// attestations( -// where: { -// attester: { equals: "0x2d7B3e18D45846DA09D78e3644F15BD4aafa634d" } -// recipient: { -// equals: "0x026B727b60D336806B87d60e95B6d7FAd2443dD6" -// } -// revoked: { equals: false } -// schemaId: { -// equals: "0x85e90e3e16d319578888790af3284fea8bca549305071531e7478e3e0b5e7d6d" -// } -// } -// ) { -// id -// attester -// recipient -// refUID -// revocable -// revocationTime -// expirationTime -// data -// } -// } -// `); -// -// // Decode each attestation's data and log it -// result.attestations.forEach((attestation: any) => { -// const decodedData = decodedAttestations(attestation.data); -// console.log({ decodedData }); -// }); -// -// // If you want to return decoded data, you can do something like this: -// const decoded = -// result && -// result.attestations.map((attestation: any) => ({ -// ...attestation, -// decodedData: decodettestationData(attestation.data), -// })); -// -// return decoded; // or return result.attestations if you don't need the decoded data in the result -// }, -// }); -// };
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/pages/Identifiers/Identifiers.tsx (3 hunks)
- src/services/eas/query.ts (2 hunks)
Additional comments not posted (7)
src/services/eas/query.ts (3)
5-5
: LGTM!The import statement for
IAttestation
is correct and necessary for type safety.The code changes are approved.
7-9
: LGTM!The
AttestationsResponse
interface is correctly defined and improves type safety and clarity.The code changes are approved.
Line range hint
12-52
: LGTM!The changes to the
useGetAttestations
hook improve type safety and clarity regarding the expected data structure returned from the GraphQL request.The code changes are approved.
src/pages/Identifiers/Identifiers.tsx (4)
Line range hint
1-19
: LGTM!The import statements are correct and necessary for the functionality of the component.
The code changes are approved.
21-29
: LGTM!The
IdentifierItemProps
interface is correctly defined and improves type safety and clarity.The code changes are approved.
31-81
: LGTM!The
IdentifierItem
component is well-structured and promotes reusability and cleaner code.The code changes are approved.
Line range hint
83-174
: LGTM!The
Identifiers
component is well-structured and the changes improve its functionality, responsiveness, and maintainability.The code changes are approved.
Summary by CodeRabbit
New Features
IdentifierItem
component for improved rendering and management of identifiers.useGetAttestations
hook for better type safety and clarity in data handling.Bug Fixes
Identifiers
component to data changes.Refactor