Merge pull request #28 from TogetherCrew/feat/close-25

close #25
TogetherCrew · Jun 6, 2024 · 2071f30 · 2071f30
2 parents 749dcdf + b907461
commit 2071f30
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/contracts/Engagement.sol b/contracts/Engagement.sol
@@ -53,6 +53,9 @@ contract EngagementContract is IEngagement, ERC1155, AccessControl {
         if (account != msg.sender) {
             revert NotAllowed(account, tokenId);
         }
+        if (tokenId >= _counter) {
+            revert NotFound(tokenId);
+        }
         _burn(account, tokenId, 1);
         emit Burn(account, tokenId, 1);
     }

diff --git a/test/engagements.ts b/test/engagements.ts
@@ -295,6 +295,18 @@ describe("Engage", function () {
             )}", ${tokenId})`
           );
         });
+        it("Should revert with NotFound (token doesn't exist)", async function () {
+          tokenId = parseUnits("999", 0);
+
+          await expect(
+            contract.write.burn(
+              [getAddress(otherAccount.account.address), tokenId, amount],
+              {
+                account: otherAccount.account.address,
+              }
+            )
+          ).to.be.rejectedWith("NotFound(999)");
+        });
       });
     });
   });