Merge pull request #24 from TogetherCrew/feat/close-23

close #23
TogetherCrew · Jun 6, 2024 · 749dcdf · 749dcdf
2 parents 153b6a4 + 12570b3
commit 749dcdf
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/contracts/Engagement.sol b/contracts/Engagement.sol
@@ -50,6 +50,9 @@ contract EngagementContract is IEngagement, ERC1155, AccessControl {
         uint tokenId,
         uint amount
     ) external override {
+        if (account != msg.sender) {
+            revert NotAllowed(account, tokenId);
+        }
         _burn(account, tokenId, 1);
         emit Burn(account, tokenId, 1);
     }

diff --git a/contracts/IEngagement.sol b/contracts/IEngagement.sol
@@ -5,6 +5,7 @@ interface IEngagement {
 
     error NotFound(uint tokenId);
     error MintLimit(address account, uint tokenId);
+    error NotAllowed(address account, uint tokenId);
 
     function counter() external view returns (uint);
 

diff --git a/test/engagements.ts b/test/engagements.ts
@@ -237,7 +237,7 @@ describe("Engage", function () {
           }
         );
       });
-      describe("Success", () => {
+      describe("Success", async function () {
         it("Should have an account balance of 0", async function () {
           const balance1 = await contract.read.balanceOf([
             getAddress(otherAccount.account.address),
@@ -281,6 +281,21 @@ describe("Engage", function () {
           );
         });
       });
+      describe("Revert", async function () {
+        it("Should revert with NotAllowed (msg.sender != account)", async function () {
+          await expect(
+            contract.write.burn([
+              getAddress(otherAccount.account.address),
+              tokenId,
+              amount,
+            ])
+          ).to.be.rejectedWith(
+            `NotAllowed("${getAddress(
+              otherAccount.account.address
+            )}", ${tokenId})`
+          );
+        });
+      });
     });
   });
 });