Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce packages for python 3.12 #226

Closed
wants to merge 3 commits into from

Conversation

dudoslav
Copy link

@dudoslav dudoslav commented Nov 18, 2024

In order to solve environments with python 3.12 we require tiledbsoma-py to support python 3.12 as well.

I removed support for pyarrow 11, not sure if that is an issue.

Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I defer to @jdblischak for expert approval on all things Conda

Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are running into the same problem as I did in #220. Unfortunately conda_build_config.yaml is not flexible enough to accommodate both the outdated py39 cloud variant and a cutting edge py312 build at the same time.

Given that we are going to want to build and test a py312 cloud environment before replacing our existing py39 cloud environment, I don't see any way around having to maintain two separate branches (one for the py39 cloud variant, and one with the latest conda-forge pins).

@@ -23,7 +23,7 @@ spdlog: # [linux]
- 1.11 # [linux]
- 1.14 # [linux]
pyarrow: # [linux]
- 11 # [linux]
- 17 # [linux]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pyarrow 11 pin is for the cloud variant we install in our py39 environment

# TileDB Cloud genomics notebook image
date
## Mon Nov 18 05:10:35 PM UTC 2024
conda list pyarrow
## # packages in environment at /opt/conda:
## #
## # Name                    Version                   Build  Channel
## pyarrow                   11.0.0          py39hf0ef2fd_5_cpu    conda-forge
## pyarrow-hotfix            0.6                pyhd8ed1ab_0    conda-forge

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately pyarrow 11 is available for py311 but not py312:

mamba create --dry-run -n test -c conda-forge python=3.11 pyarrow=11
##   + pyarrow                   11.0.0  py311hdf9aeb4_60_cpu  conda-forge        4MB

mamba create --dry-run -n test -c conda-forge python=3.12 pyarrow=11
## Could not solve for environment specs

@jdblischak
Copy link
Collaborator

Went with the 2-branch approach. Superseded by #227 and #228

@jdblischak jdblischak closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants