Fix build errors with CMake 3.29.1. #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ihnorton
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
From discussion, noting that this PR vendors the changes to vcpkg_cmake_config_fixup.cmake from microsoft/vcpkg#38017 as a root-cause fix -- so that we don't have to separately patch each downstream (until upstream fixes are all propogated).
|
Read the Docs build failed due to network failures. |
|
@KiterLuc should we backport this to 2.21? C# nightly tests are failing on that branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup` command. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017. Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it. Fixes #4857 Fixes TileDB-Inc/TileDB-CSharp#405 Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83 --- TYPE: NO_HISTORY (cherry picked from commit 690479f)
KiterLuc
pushed a commit
that referenced
this pull request
Apr 10, 2024
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup` command. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017. Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it. Fixes #4857 Fixes TileDB-Inc/TileDB-CSharp#405 Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83 --- TYPE: NO_HISTORY (cherry picked from commit 690479f)
teo-tsirpanis
added a commit
that referenced
this pull request
Apr 10, 2024
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup` command. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017. Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it. Fixes #4857 Fixes TileDB-Inc/TileDB-CSharp#405 Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83 --- TYPE: NO_HISTORY
KiterLuc
pushed a commit
that referenced
this pull request
Apr 10, 2024
Backport 690479f from #4859. --- TYPE: NO_HISTORY DESC: Fix build errors with CMake 3.29.1. Co-authored-by: Theodore Tsirpanis <[email protected]>
KiterLuc
pushed a commit
that referenced
this pull request
Apr 10, 2024
dudoslav
pushed a commit
that referenced
this pull request
Apr 17, 2024
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup` command. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017. Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it. Fixes #4857 Fixes TileDB-Inc/TileDB-CSharp#405 Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83 --- TYPE: NO_HISTORY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.29.1 had a change that broke vcpkg's
vcpkg_cmake_config_fixupcommand. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017.Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it.
Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83
TYPE: NO_HISTORY