[Backport release-2.22] Fix build errors with CMake 3.29.1. #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup` command. This PR updates the port containing the command to adapt to the new behavior. The change will be upstreamed with microsoft/vcpkg#38017. Validated locally. For ease of review, the first commit copies the existing port as-is, and the second commit updates it. Fixes #4857 Fixes TileDB-Inc/TileDB-CSharp#405 Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83 --- TYPE: NO_HISTORY (cherry picked from commit 690479f)
KiterLuc
force-pushed
the
backport-4859-to-release-2.22
branch
from
c5c82d7 to
68fd5ff
Compare
teo-tsirpanis
approved these changes
Apr 10, 2024
KiterLuc
pushed a commit
that referenced
this pull request
Apr 11, 2024
… al. (#4868) Backport 8869d17 from #4863. --- TYPE: CONFIG DESC: Add `vfs.gcs.impersonate_service_account` option that specifies a service account to impersonate, or a comma-separated list for delegated impersonation. --- TYPE: IMPROVEMENT DESC: Stop using deprecated Google Cloud SDK APIs. Co-authored-by: Isaiah Norton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 690479f from #4859.
TYPE: NO_HISTORY
DESC: Fix build errors with CMake 3.29.1.