CPack artifacts file name format compliance #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudoslav
requested review from
ihnorton,
eddelbuettel,
johnkerl,
teo-tsirpanis and
KiterLuc
teo-tsirpanis
approved these changes
Mar 13, 2024
|
Let's wait for the release in your fork to finish. |
Done |
|
I just noticed that |
teo-tsirpanis
approved these changes
Mar 13, 2024
Should be fixed, new workflow and release: https://github.com/dudoslav/TileDB/actions/runs/8267589002 |
johnkerl
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
OK I see:
tiledb-macos-x86_64-2.19.2-dc780d2.tar.gz https://github.com/TileDB-Inc/TileDB/releases/tag/2.19.2
tiledb-macos-x86_64-2.21.0.tar.gz https://github.com/TileDB-Inc/TileDB/releases/tag/2.21.0-rc0
tiledb-macos-x86_64-t14-070c5de.tar.gz https://github.com/dudoslav/TileDB/releases/tag/t14
I think this is good! Thanks @dudoslav ! 🙂
Last releases seems to have correct releases.csv: |
KiterLuc
pushed a commit
that referenced
this pull request
Mar 13, 2024
This PR fixes these concerns with release artifact filenames: 1. Windows having `amd64` in name instead of `x86_64` 2. Package name missing full tag as name 3. Package name missing commit hash Number 1. is fixed by checking CMake variabe CMAKE_SYSTEM_PROCESSOR and if its set to `AMD64` the packaging logic uses `x86_64` instead. Number 2. and 3. are fixed by packaging process requiring `TILEDB_PACKAGE_VERSION` environment variable to be present when calling packaging commands (`make package` or `cpack ...` or similar) An example pipeline in my fork: https://github.com/dudoslav/TileDB/actions/runs/8266657611 An example release `t14` in my fork: https://github.com/dudoslav/TileDB/releases/tag/t14 (Please wait for them to finish) --- TYPE: NO_HISTORY DESC: Fix CPack packaging issues with file name format (cherry picked from commit e6e1808)
KiterLuc
added a commit
that referenced
this pull request
Mar 13, 2024
…4811) (#4814) Backport e6e1808 from #4811. --- TYPE: NO_HISTORY DESC: Fix CPack packaging issues with file name format. Co-authored-by: Dušan Baran <[email protected]>
robertbindar
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR fixes these concerns with release artifact filenames: 1. Windows having `amd64` in name instead of `x86_64` 2. Package name missing full tag as name 3. Package name missing commit hash Number 1. is fixed by checking CMake variabe CMAKE_SYSTEM_PROCESSOR and if its set to `AMD64` the packaging logic uses `x86_64` instead. Number 2. and 3. are fixed by packaging process requiring `TILEDB_PACKAGE_VERSION` environment variable to be present when calling packaging commands (`make package` or `cpack ...` or similar) An example pipeline in my fork: https://github.com/dudoslav/TileDB/actions/runs/8266657611 An example release `t14` in my fork: https://github.com/dudoslav/TileDB/releases/tag/t14 (Please wait for them to finish) --- TYPE: NO_HISTORY DESC: Fix CPack packaging issues with file name format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes these concerns with release artifact filenames:
amd64in name instead ofx86_64Number 1. is fixed by checking CMake variabe CMAKE_SYSTEM_PROCESSOR and if its set to
AMD64the packaging logic usesx86_64instead.Number 2. and 3. are fixed by packaging process requiring
TILEDB_PACKAGE_VERSIONenvironment variable to be present when calling packaging commands (make packageorcpack ...or similar)An example pipeline in my fork: https://github.com/dudoslav/TileDB/actions/runs/8266657611
An example release
t14in my fork: https://github.com/dudoslav/TileDB/releases/tag/t14(Please wait for them to finish)
TYPE: NO_HISTORY
DESC: Fix CPack packaging issues with file name format