CPack artifacts file name format compliance (#4811)

This PR fixes these concerns with release artifact filenames:

1. Windows having `amd64` in name instead of `x86_64`
2. Package name missing full tag as name
3. Package name missing commit hash

Number 1. is fixed by checking CMake variabe CMAKE_SYSTEM_PROCESSOR and
if its set to `AMD64` the packaging logic uses `x86_64` instead.

Number 2. and 3. are fixed by packaging process requiring
`TILEDB_PACKAGE_VERSION` environment variable to be present when calling
packaging commands (`make package` or `cpack ...` or similar)

An example pipeline in my fork:
https://github.com/dudoslav/TileDB/actions/runs/8266657611
An example release `t14` in my fork:
https://github.com/dudoslav/TileDB/releases/tag/t14
(Please wait for them to finish)

---
TYPE: NO_HISTORY
DESC: Fix CPack packaging issues with file name format

.github/workflows/append-release-cmake.yml

@@ -38,7 +38,7 @@ jobs:
 
       - name: Render template
         run: |
-          PATTERN="tiledb-([^-]+)-([^-]+)(-noavx2)?-([^-]+).(tar.gz|zip)$"
+          PATTERN="tiledb-([^-]+)-([^-]+)(-noavx2)?-([^-]+)-([^-]+).(tar.gz|zip)$"
           RELLIST="output/releases.csv"
           MODULE="output/DownloadPrebuiltTileDB.cmake"
           cp cmake/inputs/DownloadPrebuiltTileDB.cmake $MODULE

.github/workflows/release.yml

@@ -17,9 +17,18 @@ jobs:
     steps:
       - name: Checkout TileDB
         uses: actions/checkout@v3
+      - name: Set variables
+        id: get-values
+        run: |
+          release_hash=$( echo ${{ github.sha }} | cut -c-7 - )
+          ref=${{ github.head_ref || github.ref_name }}
+          echo "release_version=${ref##*/}-$release_hash" >> $GITHUB_OUTPUT
+        shell: bash
       - name: CMake Configure
         run: cmake -S . -B build -DTILEDB_CMAKE_IDE=ON
       - name: CPack Package Source
+        env:
+          TILEDB_PACKAGE_VERSION: ${{ steps.get-values.outputs.release_version }}
         run: cd build && cpack --config CPackSourceConfig.cmake
       - name: Upload Release Artifacts
         uses: actions/upload-artifact@v3
@@ -79,8 +88,7 @@ jobs:
         run: |
           release_hash=$( echo ${{ github.sha }} | cut -c-7 - )
           ref=${{ github.head_ref || github.ref_name }}
-          echo "release_hash=$release_hash" >> $GITHUB_OUTPUT
-          echo "archive_name=tiledb-${{ matrix.platform }}-${ref##*/}-$release_hash" >> $GITHUB_OUTPUT
+          echo "release_version=${ref##*/}-$release_hash" >> $GITHUB_OUTPUT
         shell: bash
       - name: Install manylinux prerequisites
         if: matrix.manylinux
@@ -106,6 +114,8 @@ jobs:
             ${{ matrix.cmake_args }}
         shell: bash
       - name: Build TileDB
+        env:
+          TILEDB_PACKAGE_VERSION: ${{ steps.get-values.outputs.release_version }}
         run: cmake --build build --config Release --target package
       - name: Upload release artifacts
         uses: actions/upload-artifact@v3

cmake/inputs/CustomCPackOptions.cmake.in

@@ -5,3 +5,11 @@ set(CPACK_INCLUDE_TOPLEVEL_DIRECTORY OFF)
 
 # Enable HASH
 set(CPACK_PACKAGE_CHECKSUM "SHA256")
+
+set(PACKAGE_VERSION $ENV{TILEDB_PACKAGE_VERSION})
+if(NOT PACKAGE_VERSION)
+    message(FATAL_ERROR "In order to package TileDB specify environment variable TILEDB_PACKAGE_VERSION")
+endif()
+
+set(CPACK_SOURCE_PACKAGE_FILE_NAME "${CPACK_SOURCE_PACKAGE_FILE_NAME}-${PACKAGE_VERSION}")
+set(CPACK_PACKAGE_FILE_NAME "${CPACK_PACKAGE_FILE_NAME}-${PACKAGE_VERSION}")

cmake/package.cmake

@@ -29,17 +29,24 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
     else()
         set(CPACK_SYSTEM_PROCESSOR ${CMAKE_SYSTEM_PROCESSOR})
     endif()
+elseif(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+    set(CPACK_SYSTEM_NAME ${CMAKE_SYSTEM_NAME})
+    if(CMAKE_SYSTEM_PROCESSOR STREQUAL "AMD64")
+        set(CPACK_SYSTEM_PROCESSOR "x86_64")
+    else()
+        set(CPACK_SYSTEM_PROCESSOR ${CMAKE_SYSTEM_PROCESSOR})
+    endif()
 else()
     set(CPACK_SYSTEM_NAME ${CMAKE_SYSTEM_NAME})
     set(CPACK_SYSTEM_PROCESSOR ${CMAKE_SYSTEM_PROCESSOR})
 endif()
 
 set(CPACK_SOURCE_IGNORE_FILES ".*\.git;.*build.*/.*")
 
-set(CPACK_SOURCE_PACKAGE_FILE_NAME "${PROJECT_NAME}-source-${TILEDB_VERSION}")
+set(CPACK_SOURCE_PACKAGE_FILE_NAME "${PROJECT_NAME}-source")
 string(TOLOWER ${CPACK_SOURCE_PACKAGE_FILE_NAME} CPACK_SOURCE_PACKAGE_FILE_NAME)
 
-set(CPACK_PACKAGE_FILE_NAME "${PROJECT_NAME}-${CPACK_SYSTEM_NAME}-${CPACK_SYSTEM_PROCESSOR}${CPACK_NOAVX2}-${TILEDB_VERSION}")
+set(CPACK_PACKAGE_FILE_NAME "${PROJECT_NAME}-${CPACK_SYSTEM_NAME}-${CPACK_SYSTEM_PROCESSOR}${CPACK_NOAVX2}")
 string(TOLOWER ${CPACK_PACKAGE_FILE_NAME} CPACK_PACKAGE_FILE_NAME)
 
 include(CPack)