Fix memory budget tests on ASAN nightlies. #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some objects are larger on the ASAN debug build and causes us to load less tiles in memory, failing some memory budget verifications. Making the budget slightly larger fixes the tests. --- TYPE: NO_HISTORY DESC: Fix memory budget tests on ASAN nightlies.
|
This pull request has been linked to Shortcut Story #41943: Fix ASAN runs for 2024-02-28.. |
|
Run with this change passing: https://github.com/TileDB-Inc/TileDB/actions/runs/8080495156 |
teo-tsirpanis
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects are larger on the ASAN debug build and causes us to load less tiles in memory, failing some memory budget verifications. Making the budget slightly larger fixes the tests.
TYPE: NO_HISTORY
DESC: Fix memory budget tests on ASAN nightlies.