Skip to content

Commit

Permalink
Fix memory budget tests on ASAN nightlies. (#4772)
Browse files Browse the repository at this point in the history
Some objects are larger on the ASAN debug build and causes us to load
less tiles in memory, failing some memory budget verifications. Making
the budget slightly larger fixes the tests.

---
TYPE: NO_HISTORY
DESC: Fix memory budget tests on ASAN nightlies.
  • Loading branch information
KiterLuc authored Feb 28, 2024
1 parent b43ac58 commit 027c98d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/src/unit-cppapi-consolidation-with-timestamps.cc
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ TEST_CASE_METHOD(

// Will only allow to load two tiles out of 3.
Config cfg;
cfg.set("sm.mem.total_budget", "10200");
cfg.set("sm.mem.total_budget", "11000");
cfg.set("sm.mem.reader.sparse_global_order.ratio_coords", "0.4");
ctx_ = Context(cfg);

Expand Down Expand Up @@ -822,7 +822,7 @@ TEST_CASE_METHOD(

// Will only allow to load two tiles out of 3.
Config cfg;
cfg.set("sm.mem.total_budget", "10200");
cfg.set("sm.mem.total_budget", "11000");
cfg.set("sm.mem.reader.sparse_global_order.ratio_coords", "0.4");
ctx_ = Context(cfg);

Expand Down
4 changes: 2 additions & 2 deletions test/src/unit-sparse-global-order-reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ TEST_CASE_METHOD(

// Two result tile (2 * (~1200 + 8) will be bigger than the per fragment
// budget (1000).
total_budget_ = "10500";
total_budget_ = "12000";
ratio_coords_ = "0.30";
update_config();

Expand Down Expand Up @@ -1348,7 +1348,7 @@ TEST_CASE_METHOD(

// Two result tile (2 * (~1200 + 8) will be bigger than the per fragment
// budget (1000).
total_budget_ = "10500";
total_budget_ = "12000";
ratio_coords_ = "0.30";
update_config();

Expand Down

0 comments on commit 027c98d

Please sign in to comment.