Fix the aggregates CPP API install files. #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the use of concepts in std::derived_from to std::is_base_of_v to not require users of the CPP API to use c++ 20. --- TYPE: IMPROVEMENT DESC: Fix the aggregates CPP API install files.
eddelbuettel
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
This still missed cpp_api/channel_operator.h. Once I add that (as I did in 2a27744) then the R package builds and installs (and of course tests) fine against this PR.
Thanks for fixing this. May be best to wait for CI before merging even though my one-line catch-up commit should not have created harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the use of concepts in std::derived_from to std::is_base_of_v to not require users of the CPP API to use c++ 20.
SC-35774
TYPE: NO_HISTORY
DESC: Fix the aggregates CPP API install files.