Skip to content

Commit

Permalink
Fix the aggregates CPP API install files. (#4441)
Browse files Browse the repository at this point in the history
This also changes the use of concepts in std::derived_from to
std::is_base_of_v to not require users of the CPP API to use c++ 20.

SC-35774

---
TYPE: IMPROVEMENT
DESC: Fix the aggregates CPP API install files.

---------

Co-authored-by: Dirk Eddelbuettel <[email protected]>
  • Loading branch information
KiterLuc and eddelbuettel authored Oct 23, 2023
1 parent 54bd64b commit 10a45d7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
3 changes: 3 additions & 0 deletions tiledb/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ if (TILEDB_CPP_API)
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/as_built_experimental.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/attribute.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/attribute_experimental.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/channel_operation.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/channel_operator.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/config.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/consolidation_plan_experimental.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/context.h
Expand All @@ -112,6 +114,7 @@ if (TILEDB_CPP_API)
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/object.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/object_iter.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/query.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/query_channel.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/query_condition_experimental.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/query_condition.h
${TILEDB_CORE_INCLUDE_DIR}/tiledb/sm/cpp_api/query_experimental.h
Expand Down
4 changes: 3 additions & 1 deletion tiledb/sm/cpp_api/channel_operation.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ class ChannelOperation {
* @param query The TileDB query
* @param input_field The attribute name the aggregate operation will run on
*/
template <std::derived_from<ChannelOperator> Op>
template <
class Op,
std::enable_if_t<std::is_base_of_v<ChannelOperator, Op>, bool> = true>
static ChannelOperation create(
const Query& query, const std::string& input_field) {
const Context& ctx = query.ctx();
Expand Down
4 changes: 3 additions & 1 deletion tiledb/sm/cpp_api/query_experimental.h
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,9 @@ class QueryExperimental {
* @param input_field The attribute name as input for the aggregate
* @return The aggregate operation
*/
template <std::derived_from<ChannelOperator> Op>
template <
class Op,
std::enable_if_t<std::is_base_of_v<ChannelOperator, Op>, bool> = true>
static ChannelOperation create_unary_aggregate(
const Query& query, const std::string& input_field) {
return ChannelOperation::create<Op>(query, input_field);
Expand Down

0 comments on commit 10a45d7

Please sign in to comment.