Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows nighty builds. #4300

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix Windows nighty builds. #4300

merged 2 commits into from
Aug 29, 2023

Conversation

teo-tsirpanis
Copy link
Member

Fixes #4299. A test run has launched on my fork.

TYPE: NO_HISTORY

@teo-tsirpanis
Copy link
Member Author

All right, nightlies now work on Windows.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review August 29, 2023 12:15
ihnorton
ihnorton approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ihnorton ihnorton merged commit 880d3b2 into TileDB-Inc:dev Aug 29, 2023
51 checks passed
@teo-tsirpanis teo-tsirpanis deleted the fix-nightly branch September 15, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@davisp davisp Awaiting requested review from davisp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly GitHub Actions Build Fail on Tue, August 29th 2023
2 participants
@teo-tsirpanis @ihnorton