Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows nighty builds. #4300

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix Windows nighty builds. #4300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
865e138
Fix Windows nighty builds.
teo-tsirpanis Aug 29, 2023
4f39d71
Fix more errors.
teo-tsirpanis Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tiledb/api/c_api/vfs/test/unit_capi_vfs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,11 +591,13 @@ TEST_CASE("C API: tiledb_vfs_read argument validation", "[capi][vfs]") {
CHECK(tiledb_status(rc) == TILEDB_ERR);
}
SECTION("invalid offset") {
auto rc{tiledb_vfs_read(x.ctx, x.vfs_fh, -1, buffer, 0)};
auto rc{
tiledb_vfs_read(x.ctx, x.vfs_fh, static_cast<uint64_t>(-1), buffer, 0)};
CHECK(tiledb_status(rc) == TILEDB_ERR);
}
SECTION("invalid number of bytes") {
auto rc{tiledb_vfs_read(x.ctx, x.vfs_fh, 0, buffer, -1)};
auto rc{
tiledb_vfs_read(x.ctx, x.vfs_fh, 0, buffer, static_cast<uint64_t>(-1))};
CHECK(tiledb_status(rc) == TILEDB_ERR);
}
}
Expand Down
4 changes: 2 additions & 2 deletions tiledb/sm/subarray/test/unit_range_subset.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ TEMPLATE_TEST_CASE_SIG(

// Integer-type ranges will coalesce and needn't be merged.
// Float-type ranges cannot coalesce and will only be sorted.
if (D == Datatype::FLOAT32 || D == Datatype::FLOAT64) {
if constexpr (D == Datatype::FLOAT32 || D == Datatype::FLOAT64) {
CHECK(range_subset.num_ranges() == 4);
ThreadPool pool{2};
range_subset.sort_and_merge_ranges(&pool, merge);
Expand Down Expand Up @@ -409,7 +409,7 @@ TEMPLATE_TEST_CASE_SIG(
range_subset.sort_and_merge_ranges(&pool, merge);

// Check range results.
if (D == Datatype::FLOAT32 || D == Datatype::FLOAT64) {
if constexpr (D == Datatype::FLOAT32 || D == Datatype::FLOAT64) {
CHECK(range_subset.num_ranges() == 4);
check_subset_range_values(range_subset, 0, data1[0], data1[1]);
check_subset_range_values(range_subset, 1, data3[0], data3[1]);
Expand Down
Loading