Patch 2 #14
Open
Patch 2 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer having the pxHighPriWoken as an optional pointer to CAN_read_frame. The return value could be a bit confusing as the user might expect something like worked/didnt work. Having an optional pointer is a better API I think. void CAN_read_frame(BaseType_t* fYieldRequired) or similar |
…y reference (the compiler ensures all code pathes return a result)
|
here we go... |
|
What's the status on this? I know it has been a long time. |
|
how is it going here? |
hong547
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it should the speedup work and the patch compile. Sorry, I'm new at github and I transfer the patches manually from my own project to the online repo.