Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue - Update ruby version #63

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

karimdevelops
Copy link
Contributor

@karimdevelops karimdevelops commented Oct 21, 2024

Because

This pull request links to my prev pull request
I have bumped it in ruby_testing.

This PR

  • Bump ruby version to 3.3.5 in ruby_testing

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. String spec: Update instructions for clarity
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes changes in the spec folder, they are also updated in the corresponding file in the spec_answers folder (with passing tests).

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to try bundling in this repo as well. I don't expect it to fail because there are very few dependencies here.

But you'll have to navigate back to this project, run bundle install, and then add, commit, and push those changes.

Let me know if there are any problems with that.

@karimdevelops
Copy link
Contributor Author

@JoshDevHub I did mention that it ran without a problem a few days. So its fine, no error was returned

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see this Gemfile doesn't specify ruby version stuff. That should be okay then. I'll go ahead and merge it.

@JoshDevHub JoshDevHub merged commit 041b5cb into TheOdinProject:main Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants