-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby Course: Installing Ruby - Update ruby version #28973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this change!
We like to keep the Ruby version that's used in this installation lesson in sync with the Ruby version that is used for other repos in The Odin Project.
Would you be okay with bumping the Ruby versions in the Main App repo and the Ruby testing repo? If you've never done that type of thing and don't feel comfortable doing so, I can handle it myself. Just wanted to offer to you if you're interested.
I'd love it do it! But sadly I am not exactly sure how to do it... Should I just clone it, make changes in the markdown file and then make a pull request? I really want to do it, I'd appreciate your help. |
@karimdevelops You'll need to do a few things
If you have any other questions about any of those instructions, just let me know and I'll be glad to answer them. |
@JoshDevHub It successfully worked! I will make a PR soon. edit: CI is left... I suppose I need to follow this? edit2: 3/4 tests ran successfully, I cannot run rspec test :/
|
@karimdevelops I wouldn't worry about testing your changes locally. There are a lot of things that need to be set up, and I don't want you to have to jump through all that. Instead just make a PR to the main theodinproject repo. There will be tests that take your changes and run remotely in an environment that has everything configured and set up already. These tests are what I meant by "CI". If the PR passes CI, it should be fine to merge it. |
Sure mate |
@JoshDevHub I will create two seperate pull requests, I guess? Creating them now edit: You can check them now: Main repo and Ruby testing |
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because <!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. --> This pull request links to my prev [pull request](TheOdinProject/curriculum#28973) I have bumped it in the main repo ## This PR <!-- A bullet point list of one or more items describing the specific changes. --> - Bump ruby version to 3.3.5 in main repo ## Pull Request Requirements <!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. --> - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `location of change: brief description of change` format, e.g. `String spec: Update instructions for clarity` - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [x] If this PR includes changes in the `spec` folder, they are also updated in the corresponding file in the `spec_answers` folder (with passing tests).
Because
The latest stable version is 3.3.5 and there are no major changes:
Link: https://www.ruby-lang.org/en/news/2024/09/03/3-3-5-released/
This PR
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section