Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Compatibility lesson: Add link to infographic video #28825

Closed
wants to merge 1 commit into from
Closed

Browser Compatibility lesson: Add link to infographic video #28825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion intermediate_html_css/intermediate_css_concepts/browser_compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

In 1995 the world got introduced to the first version of Internet Explorer, which became the dominant player in the market. At some point, Internet Explorer was used by more than 90% of all users. To counter this dominance, Netscape launched what would become Mozilla Foundation which develops and maintains Firefox. Soon after that, in 2003, Apple launched Safari, and in 2008, Google launched Chrome.

You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day, even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>.
You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day (as seen in [this infographic video](https://www.youtube.com/watch?v=W4wWdmfOibY)), even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>.

Check failure on line 23 in intermediate_html_css/intermediate_css_concepts/browser_compatibility.md

View workflow job for this annotation

GitHub Actions / Lint lesson files

Links have descriptive text labels 

intermediate_html_css/intermediate_css_concepts/browser_compatibility.md:23 TOP001/descriptive-link-text Links have descriptive text labels [Expected text to not include the words "this" or "here". Use a more descriptive text that clearly conveys the purpose or content of the link.] [Context: "[this infographic video](https://www.youtube.com/watch?v=W4wWdmfOibY)"] https://github.com/TheOdinProject/curriculum/blob/main/markdownlint/docs/TOP001.md
Copy link
Contributor

@MaoShizhong MaoShizhong Sep 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For accessibility, we need to make sure links have descriptive labels without "this" or "here". Otherwise, users with screen readers navigating by links would simply get something like "this infographic video - link" read out to them, which does not provide sufficient context for what the linked resource is about or what site it leads to.

Below is a minimally invasive suggestion that should provide enough description for the link.

Suggested change
You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day (as seen in [this infographic video](https://www.youtube.com/watch?v=W4wWdmfOibY)), even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>.
You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of [competition among browsers](https://www.youtube.com/watch?v=W4wWdmfOibY) still to this day, even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>.


### What is browser compatibility?

Expand Down
Loading