Browser Compatibility lesson: Add link to infographic video #28825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added link to infographic video detailing the "browser wars" Resolves issue TheOdinProject#28783
github-actions
bot
added
the
Content: Intermediate HTML/CSS
MaoShizhong
suggested changes
Sep 21, 2024
| @@ -20,7 +20,7 @@ The release of Nexus was just the beginning though, as in the next decade people | |||
|
|
|||
| In 1995 the world got introduced to the first version of Internet Explorer, which became the dominant player in the market. At some point, Internet Explorer was used by more than 90% of all users. To counter this dominance, Netscape launched what would become Mozilla Foundation which develops and maintains Firefox. Soon after that, in 2003, Apple launched Safari, and in 2008, Google launched Chrome. | |||
|
|
|||
| You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day, even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>. | |||
| You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day (as seen in [this infographic video](https://www.youtube.com/watch?v=W4wWdmfOibY)), even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>. | |||
There was a problem hiding this comment.
For accessibility, we need to make sure links have descriptive labels without "this" or "here". Otherwise, users with screen readers navigating by links would simply get something like "this infographic video - link" read out to them, which does not provide sufficient context for what the linked resource is about or what site it leads to.
Below is a minimally invasive suggestion that should provide enough description for the link.
Suggested change
| You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of competition among browsers still to this day (as seen in [this infographic video](https://www.youtube.com/watch?v=W4wWdmfOibY)), even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>. | |
| You're most likely familiar with most, if not all these names.<span id="most-used-browser"> There is a lot of [competition among browsers](https://www.youtube.com/watch?v=W4wWdmfOibY) still to this day, even though Chrome (and [Chromium](https://en.wikipedia.org/wiki/Chromium_(web_browser))) is the dominant player in the market</span>. |
|
Just bumping this to say I will get this done today or tomorrow. Had surgery a few weeks ago, so I've been out while on meds and in pain. Now I'm feeling up to work, so I'll get right to this. Didn't know about the accessibility issue with pronouns inside link descriptive labels, so I'll keep it in mind for the future. |
|
Superceded by #28959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link to infographic video detailing the "browser wars"
Resolves issue #28783
Because
An additional link to a video detailing the "browser wars" will quickly catch visual learners up to speed on why Chrome is the browser choice for TOP as well as give them a brief visual history of browsers, in general.
This PR
Issue
Closes #28783
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection