Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations: Remove reference to the show Silicon Valley (tabs vs spaces) #28691

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Foundations: Remove reference to the show Silicon Valley (tabs vs spaces) #28691

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7aa07a
Remove reference to the show Silicon Valley
mathdebate09 Aug 23, 2024
ee27e91
Add a reference to reddit thread on tabs vs space discussion
mathdebate09 Aug 23, 2024
6dfda6a
Rephrase the joke reference
mathdebate09 Aug 24, 2024
0b767b0
Rephrasing nits
mathdebate09 Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundations/javascript_basics/clean_code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ You might wonder why this variable is declared with all caps when we recommended

### Indentation and line length

Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a joke by now, as demonstrated in the [tabs versus spaces scene from the show Silicon Valley](https://www.youtube.com/watch?v=SsoOG6ZeyUI).
Now it's time to head to more "controversial" topics (there's a joke about the [war between coders who indent with spaces versus tabs](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/)).

What actually matters is *consistency*. Choose a way to indent and stick to it. Various JavaScript style guides recommend different options, and one is not really superior to the other. We will look at style guides and related tools in more detail later in the curriculum.

Expand Down