Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations: Remove reference to the show Silicon Valley (tabs vs spaces) #28691

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

mathdebate09
Copy link
Contributor

@mathdebate09 mathdebate09 commented Aug 23, 2024

Because

The video was unavailable and rather unhelpful and had a constant risk of being taken down, thus removing it.

This PR

  • Remove the video link
  • Add a Reddit discussion

Issue

Closes #28682

Additional Information

I'm somewhat doubtful of the reddit discussion, let me know if needs to be removed, lgtm

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Aug 23, 2024
@mathdebate09 mathdebate09 changed the title Founddations: Remove reference to the show Silicon Valley (tabs vs spaces) Foundations: Remove reference to the show Silicon Valley (tabs vs spaces) Aug 23, 2024
Co-authored-by: MaoShizhong <[email protected]>
Co-authored-by: MaoShizhong <[email protected]>
@MaoShizhong MaoShizhong merged commit a4b692e into TheOdinProject:main Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Code: <Tabs vs Spaces link leads to a private video>
3 participants