Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency #16

Closed
wants to merge 6 commits into from
Closed

Update dependency #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a3b62b
fix(dependency): update symfony-console dependency, php-version depen…
lliyplliuk Dec 9, 2023
5a12a89
doc(manual-install): set version
lliyplliuk Dec 9, 2023
5401d7f
Revert "doc(manual-install): set version"
lliyplliuk Dec 9, 2023
e3f0e6c
Revert "fix(dependency): update symfony-console dependency, php-versi…
lliyplliuk Dec 9, 2023
5173c67
doc(manual-install): set version
lliyplliuk Dec 9, 2023
024fdef
refactor(dependency): update dependency
lliyplliuk Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Or manually update `require-dev` block of `composer.json` and run `composer upda
```json
{
"require-dev": {
"dragon-code/benchmark": "^2.0"
"dragon-code/benchmark": "^2.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to specify a minor version in the description, as specifying ^2.0 will cause the composer to install the most recent version from the second series.

}
}
```
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
}
],
"require": {
"php": "^8.1",
"php": ">=8.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense to do this within PHP 8, as both will require PHP 8.1.0 or higher.

But the >= option may be dangerous in the future, as all versions above 8.1.0 will fall under it. For example, 9, 10, 11 and so on.

"dragon-code/support": "^6.10",
"symfony/console": "^5.3 || ^6.0"
"symfony/console": "^5.3 || >=6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, you should not use versioning with >=, as it will not only include Symfony version 6, but also 7, 8, and so on.

It is better to add tests for version 7 and specify it explicitly. This way we will make sure that the package works with version 7.

},
"require-dev": {
"phpunit/phpunit": "^10.0",
Expand Down