Update dependency #16
Conversation
| @@ -22,7 +22,7 @@ Or manually update `require-dev` block of `composer.json` and run `composer upda | |||
| ```json | |||
| { | |||
| "require-dev": { | |||
| "dragon-code/benchmark": "^2.0" | |||
| "dragon-code/benchmark": "^2.5" | |||
There was a problem hiding this comment.
There is no need to specify a minor version in the description, as specifying ^2.0 will cause the composer to install the most recent version from the second series.
| @@ -41,9 +41,9 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^8.1", | |||
| "php": ">=8.1", | |||
There was a problem hiding this comment.
It makes no sense to do this within PHP 8, as both will require PHP 8.1.0 or higher.
But the >= option may be dangerous in the future, as all versions above 8.1.0 will fall under it. For example, 9, 10, 11 and so on.
| "dragon-code/support": "^6.10", | ||
| "symfony/console": "^5.3 || ^6.0" | ||
| "symfony/console": "^5.3 || >=6.0" |
There was a problem hiding this comment.
In this case, you should not use versioning with >=, as it will not only include Symfony version 6, but also 7, 8, and so on.
It is better to add tests for version 7 and specify it explicitly. This way we will make sure that the package works with version 7.
|
Version 2.6.0 has been released with support for Symfony 7. Thanks for your idea! |
|
mybe you also update dragon-code/contracts symfony/http-kernel version dependency? |
|
Ready. Thank you! |
No description provided.