Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adam optimizer #590

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add Adam optimizer #590

merged 3 commits into from
Oct 23, 2023

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Oct 22, 2023

Pull Request Template

Description

  • Add adam.rs (Adaptive Moment Estimation) optimizer algorithm to src/machine_learning/optimization
  • Add 10 test cases to adam.rs, including two for convergence testing tagged #[ignore]

Ref #578

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 2cd915d into TheAlgorithms:master Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants