Set arm and shooter in speaker command group #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terInSpeakerCommandGroup
stephenjust
requested changes
Feb 9, 2024
| @@ -144,11 +145,12 @@ public void setupMobilityComands( | |||
|
|
|||
| @Inject | |||
| public void scoringCommands( | |||
| SetArmAndShooterForAmpCommandGroup setArmAndShooterForAmpCommand | |||
| SetArmAndShooterForAmpCommandGroup setArmAndShooterForAmpCommand, | |||
There was a problem hiding this comment.
Command group classes need @Inject on construvtors
stephenjust
requested changes
Feb 9, 2024
| @@ -4,6 +4,7 @@ | |||
| import xbot.common.command.BaseSetpointCommand; | |||
|
|
|||
| import javax.inject.Inject; | |||
| import javax.inject.Singleton; | |||
There was a problem hiding this comment.
Commands should generally not be Singletons, and importing isn't enough to make it one.
| @@ -1,5 +1,8 @@ | |||
| package competition.subsystems.shooter; | |||
|
|
|||
| import javax.inject.Inject; | |||
| import javax.inject.Singleton; | |||
|
|
|||
| public class ShooterDistanceToRpmConverter { | |||
There was a problem hiding this comment.
If you wanted this to be an injectable @Singleton you need to add that annotation to the class
There was a problem hiding this comment.
Likewise the constructor would need the @Inject annotation.
…am488/XBot2024 into SetArmAndShooterInSpeakerCommandGroup
stephenjust
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Allows robot to dynamically adjust shooter arm position and shooter wheel rpm based on distance from speaker.
Asana task URL:
https://app.asana.com/0/38541457243752/1206397655151707
Whats changing?
Add SetArmAndShooterInSpeakerCommandGroup
Questions/notes for reviewers
How this was tested