-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set arm and shooter in speaker command group #86
Conversation
…terInSpeakerCommandGroup
@@ -144,11 +145,12 @@ public void setupMobilityComands( | |||
|
|||
@Inject | |||
public void scoringCommands( | |||
SetArmAndShooterForAmpCommandGroup setArmAndShooterForAmpCommand | |||
SetArmAndShooterForAmpCommandGroup setArmAndShooterForAmpCommand, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command group classes need @Inject
on construvtors
@@ -4,6 +4,7 @@ | |||
import xbot.common.command.BaseSetpointCommand; | |||
|
|||
import javax.inject.Inject; | |||
import javax.inject.Singleton; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands should generally not be Singletons, and importing isn't enough to make it one.
@@ -1,5 +1,8 @@ | |||
package competition.subsystems.shooter; | |||
|
|||
import javax.inject.Inject; | |||
import javax.inject.Singleton; | |||
|
|||
public class ShooterDistanceToRpmConverter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted this to be an injectable @Singleton
you need to add that annotation to the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise the constructor would need the @Inject
annotation.
…am488/XBot2024 into SetArmAndShooterInSpeakerCommandGroup
Why are we doing this?
Allows robot to dynamically adjust shooter arm position and shooter wheel rpm based on distance from speaker.
Asana task URL:
https://app.asana.com/0/38541457243752/1206397655151707
Whats changing?
Add SetArmAndShooterInSpeakerCommandGroup
Questions/notes for reviewers
How this was tested