Move practice robot motor details over to Practice contract to prepare for Competition chassis #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGilb
previously requested changes
Feb 9, 2024
| return true; | ||
| } | ||
|
|
||
| private String getDriveControllerName(SwerveInstance swerveInstance) { |
There was a problem hiding this comment.
We can remove these 3 methods from this class and make the ones in Competition contract protected instead of private.
| }; | ||
| } | ||
|
|
||
| public DeviceInfo getCollectorMotor() { |
There was a problem hiding this comment.
we don't need motor definitions for anything other than the drive; the practice robot doesn't have any other relevant mechanism
| } | ||
|
|
||
| @Override | ||
| public boolean isCollectorReady() { |
There was a problem hiding this comment.
same here, no "collector" on the practice robot.
| return new DeviceInfo("CollectorSolenoid", 2, false); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
same here, all the LightsDio can stay in competition
| return false; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
don't need motor definitions for devices the practice robot doesn't have
aschokking
approved these changes
Feb 9, 2024
stephenjust
approved these changes
Feb 9, 2024
stephenjust
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
To put the correct contract numbers
Asana task URL:
Whats changing?
changing the guessed numbers to correct ones
Questions/notes for reviewers
How this was tested