-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move practice robot motor details over to Practice contract to prepare for Competition chassis #85
Conversation
return true; | ||
} | ||
|
||
private String getDriveControllerName(SwerveInstance swerveInstance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove these 3 methods from this class and make the ones in Competition contract protected
instead of private
.
}; | ||
} | ||
|
||
public DeviceInfo getCollectorMotor() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need motor definitions for anything other than the drive; the practice robot doesn't have any other relevant mechanism
} | ||
|
||
@Override | ||
public boolean isCollectorReady() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, no "collector" on the practice robot.
return new DeviceInfo("CollectorSolenoid", 2, false); | ||
} | ||
|
||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, all the LightsDio
can stay in competition
return false; | ||
} | ||
|
||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need motor definitions for devices the practice robot doesn't have
Why are we doing this?
To put the correct contract numbers
Asana task URL:
Whats changing?
changing the guessed numbers to correct ones
Questions/notes for reviewers
How this was tested