-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getArmAngleFromDistance method #75
Conversation
@@ -225,6 +228,11 @@ public double convertShooterAngleToTicks(double angle) { | |||
return 0; | |||
} | |||
|
|||
public double getArmAngleFromDistance(double distance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ Consider writing a unit test for this logic to make sure you get a number you'd roughly expect (ie not a crazy negative value given a reasonable distance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ One possible problem though. Right now, I've made it so that the test checks three values for the equation for with a big range of error. I'm not really sure if this is "future-proof" if the equation changes dramatically in the future.
Why are we doing this?
Convert robot distance from speaker to angle the robot needs to be at
Asana task URL: https://app.asana.com/0/38541457243752/1206500303486160/f
Whats changing?
Added new method and changed names of some double properties to avoid confusion
Questions/notes for reviewers
How this was tested