Added getArmAngleFromDistance method #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
approved these changes
Feb 3, 2024
| @@ -225,6 +228,11 @@ public double convertShooterAngleToTicks(double angle) { | |||
| return 0; | |||
| } | |||
|
|
|||
| public double getArmAngleFromDistance(double distance) { | |||
There was a problem hiding this comment.
⭐ ⭐ Consider writing a unit test for this logic to make sure you get a number you'd roughly expect (ie not a crazy negative value given a reasonable distance).
There was a problem hiding this comment.
✅ One possible problem though. Right now, I've made it so that the test checks three values for the equation for with a big range of error. I'm not really sure if this is "future-proof" if the equation changes dramatically in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Convert robot distance from speaker to angle the robot needs to be at
Asana task URL: https://app.asana.com/0/38541457243752/1206500303486160/f
Whats changing?
Added new method and changed names of some double properties to avoid confusion
Questions/notes for reviewers
How this was tested