Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for the two commands under shooter #73

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

rzhai2
Copy link
Contributor

@rzhai2 rzhai2 commented Feb 3, 2024

Why are we doing this?

Test the WarmUpShooterCommand and the WarmUpShooterRPMCommand
Asana task URL:

Whats changing?

Added two files under the test folder: WarmUpShooterCommandTest and WarmUpShooterRPMCommandTest

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@rzhai2 rzhai2 requested a review from a team as a code owner February 3, 2024 20:50
Copy link
Contributor

@aschokking aschokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rzhai2 rzhai2 merged commit d440b99 into main Feb 3, 2024
1 check passed
@rzhai2 rzhai2 deleted the WarmUpShooterCommandTest branch February 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants