Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement serial lights #332

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

re-implement serial lights #332

wants to merge 8 commits into from

Conversation

j0ndough
Copy link
Contributor

@j0ndough j0ndough commented Dec 15, 2024

Why are we doing this?

reduces electrical team overhead with respect to wiring, adds potential flexibility to # of lights down the line

Asana task URL:

Whats changing?

re-implemented lights over serial communication (via USB) and removed previous DIO implementation.

added checks in BaseRobot to detect which USB port has a USB drive plugged in (currently just checks if device in first port > 10 MB in capacity). assigns log location to this port if true, otherwise falls back to other port.

Questions/notes for reviewers

I was not able to test this implementation with a working USB drive. Lights over serial works regardless of which ports are occupied, but will need to verify if logs are being written to the drive.

Important note: If USB devices are unplugged/replugged into different ports without restarting the RoboRIO, this implementation breaks.

How this was tested

  • unit tests added
  • tested on robot

@j0ndough j0ndough requested a review from a team as a code owner December 15, 2024 08:03
@j0ndough j0ndough changed the title Serial lights re-implement serial lights Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant