Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
reduces electrical team overhead with respect to wiring, adds potential flexibility to # of lights down the line
Asana task URL:
Whats changing?
re-implemented lights over serial communication (via USB) and removed previous DIO implementation.
added checks in BaseRobot to detect which USB port has a USB drive plugged in (currently just checks if device in first port > 10 MB in capacity). assigns log location to this port if true, otherwise falls back to other port.
Questions/notes for reviewers
I was not able to test this implementation with a working USB drive. Lights over serial works regardless of which ports are occupied, but will need to verify if logs are being written to the drive.
Important note: If USB devices are unplugged/replugged into different ports without restarting the RoboRIO, this implementation breaks.
How this was tested